- This topic has 31 replies, 2 voices, and was last updated 17 years, 8 months ago by
.
-
Posts
-
Riyad,
I finally had chance to install the MyEclipse 5.5 milestone 1 and see if the JSP validation problem has been fixed. It has not. I took the same test project that I sent you back in November. I created some invalid JSTL tags and saved the file. No validation errors were displayed.
I just tested it and see what you mean, they are marked as warnings in the editor, but not in the view or as errors. I’ll file it as a bug.
Riyad,
I just read the following post at TheServerSide.com and it made me think of my experience with MyEclipse and this particular bug:
http://www.theserverside.com/blogs/thread.tss?thread_id=44418&asrc=EM_NLN_1050606&uid=2742649
Take a look at this post too:
http://brian.pontarelli.com/2007/02/15/why-intellij-will-always-win/I ask that you share these with your developers because I see similar behavior with MyEclipse. Why do I say this? This bug is a good example. I initially found this bug in a 4.0.x or 4.1.x release. It was finally fixed in 4.1.1. Then, when I tested 5.0, it was broken. It was still broken in 5.1 and it is still broken in the 5.5 milestone 1 release.
If this was an obscure bug, I could understand it. But am I the only developer that likes to centralize his/her JAR files in one project instead of copying them to every Web project? This becomes a maintenance problem. And JSP/JSTL/Struts tag validation is critical to working productively with JSP pages.
On the flip side, I think MyEclipse’s customer support is the best I have ever seen. You all that answer this support forum are the most reponsive of all the customer support organizations that I have worked with. I think this is why I care so much about MyEclipse. So I ask again, please share this with your developers. Hopefully, they will focus more effort on bug fixes and improved testing so bugs don’t crop up again once fixed and less on adding new bells and whistles.
Keith
Keith this is just not right, to have an issue like this open for so long. A lot of this is my fault, management has to juggle so much it’s up to me to convey “must haves” from the community for each release and I didn’t convey these taglib issues clearly enough. I know 5.1.1 is too close to getting released to get this fix (this week) but I am going to see if I can force these and some other taglib fixes into 5.5 just by sheer will power and bribery.
Riyad,
I can’t tell you enough how much I would appreciate your efforts in getting this problem resolved. This problem is so fundamental in my ability to use MyEclipse, that I am still using 4.1.1 waiting for this bug to be fixed. It would be a major step backwards in my productivity for me to upgrade to 5.1 even though there are major improvements in other areas of MyEclipse and in Eclipse 3.2.x.
A friend of my uses IntelliJ, and he has encouraged me to check it out. I have resisted it because I like and know Eclipse/MyEclipse. But as I see MyEclipse continue to expand with new tools, and now SNAP for other platforms, I am seriously questioning MyEclipse’s commitment to providing a robust, professional development for hardcore, down in the trenches J2EE developers.
Thanks again for your feedback.
KeithKeith,
After some more testing I think I was looking at the wrong thing, can you download this archive and import all the test projects from it, then go to Project > Clean and see if you see warning markers for all the invalid tags and attributes?I need you to try with a 5.1.0 setup laying around, if you don’t have one, you can go to our Download section and download our 5.1.0 All-In-One installer and install it to a new location. It should be all setup and ready to go, create a new workspace and import those projects and clean them and make sure you see validation markers on the TestMyEclipse and TestKeithValidation projects.
Just a quick update, besides the tests above, management boosted the priority of taglib resolution from external projects and some core bugs related to this were fixed today which improved this situation as well.
Riyad,
I followed your instructions.
After some more testing I think I was looking at the wrong thing, can you download this archive and import all the test projects from it, then go to Project > Clean and see if you see warning markers for all the invalid tags and attributes?
I need you to try with a 5.1.0 setup laying around, if you don’t have one, you can go to our Download section and download our 5.1.0 All-In-One installer and install it to a new location. It should be all setup and ready to go, create a new workspace and import those projects and clean them and make sure you see validation markers on the TestMyEclipse and TestKeithValidation projects.
I had an existing Eclipse 3.2.1 / MyEclipse 5.1.0 installation. I created a new workspace and imported the projects. I had to add the “src” directory to both projects TestCommon and TestKeithValidation. Then I performed a clean on all projects.
Here is what I saw:
When I opened the test.jsp file in the TestKeithValidation project, it showed two warning symbols in the lefthand side of the editor (In MyEclipse 4.1.1, these would be errors), the tags with warnings were underlined with a yellow line and yellow boxes appear in the righthand side of the editor. Then, I selected the file in the package explorer view and selected MyEclipse/Run Validation on the file. The warning symbols dissappeared on the lefthand side of the editor and the warnings were no longer listed in the Problems view. But, the tags were still underlined and the yellow boxes still appeared in the righthand side of the editor.
When I performed the same steps in the TestMyEclipse project as I did above, I got the exact same results.
I created another workspace and repeated the same steps for both projects. Same results.
Good luck and thanks for raising the priority on this problem.
Keith
Keith,
Thank you for the heads up, but this seems to be a separate bug, you confirmed the issue that I was curious about, that validation and autocomplete is working correctly (except now they are marked as warnings and not as errors as before)I will file this new bug and see if it can get resolved quickly.
Riyad,
I am confused. How can you say validation is working? When I run “MyEclipse/Run Validation” from the context menu, the warnings dissappear.
Now, are you ready for a twist in this problem, which may help identify the cause? If the test.jsp file is open in either the MyEclipse JSP Editor or the MyEclipse Visual JSP Designer, the warning icons disappear from the left side of the editor when I run “MyEclipse/Run Validation” from the context menu. The warnings also disappear from the Problems View pane that is normally below the editor pane.
If I close the test.jsp file, select the file in the Package Explorer and then run “MyEclipse/Run Validation” from the context menu, the warnings reappear in the Problems view pane. Then, when I open the file in the editor (either one), the warning icons appear in the left side of the editor.
I just stumbled across this when I was testing the auto-complete to see if it was working. BTW, it works for me too.
Good luck.
KeithKeith,
Don’t interpret my comments as “looks good, have a nice day” I just broke this thread into 3 separate PRs that have been filed in our issue tracker and the first two (validation and autocomplete) seem to work, but you have found another one when forcing validation on a file that is open in an editor the markers are removed (that’s a separate bug), because if these files aren’t open in an editor the issue doesn’t come up.So that’s what I meant by validation working, there is some other bug with the error markers getting cleared out though that we will address.
Riyad,
Don’t interpret my comments as “looks good, have a nice day”
I didn’t interpret it that way, I know you and your company are taking this seriously and are being very helpful. I just didn’t understand what you meant. I don’t have your understanding of how MyEclipse works like you do. I also don’t understand the relationship between the warnings on the left and the yellow boxes on the right side of the editor.
The warnings and errors that appear on the left side of the editor and what appears in the Problem view are what I am use to looking at because that is what Eclipse displays when validating Java files. I use the colored boxes on the right side too, but I am not use to looking at them to determine if something is valid or not.
I took the ZIP file that you asked me to test today and loaded it into MyEclipse 4.1.1 to see how it validated. I noticed that 5.1.0 is validating more things, which is cool. In 4.1.1, the validator only flagged the invalid tag <c:i> as an error, it didn’t catch the invalid attributes. Very cool.
Thanks again. I really appreciate your effort today to get these problems resolved so I can start using the latest MyEcplise.
Keith
Hi Riyad,
I tested MyEclipse 5.5 M2 to see if the JSP validation bugs that I found in the previous milestone and 5.1.x were fixed. Everything appears to be working except for the very last bug that was found. I searched back through this message thread to find a description of the bug. Here is an excerpt from my posting on Feb 28, 2007 @ 06:03 PM:
When I opened the test.jsp file in the TestKeithValidation project, it showed two warning symbols in the lefthand side of the editor (In MyEclipse 4.1.1, these would be errors), the tags with warnings were underlined with a yellow line and yellow boxes appear in the righthand side of the editor. Then, I selected the file in the package explorer view and selected MyEclipse/Run Validation on the file. The warning symbols dissappeared on the lefthand side of the editor and the warnings were no longer listed in the Problems view. But, the tags were still underlined and the yellow boxes still appeared in the righthand side of the editor.
Do you remember this problem? Do you know if it was marked fixed in the this milestone?
The problem also occurs if you edit a JSP file and save it. When you save it, the warning icons on the left side disappear and the warnings disappear from the “Problems” view.
I discovered something different in 5.1 and 5.5 from 4.1.1. The validation of JSTL and Struts tags are controlled by the HTML validator preference (5.1.x and 5.5) instead of the JSP validator preference (4.1.1). This explains why no validation of these tags were occuring in my projects because I run with the HTML validator disabled. This change creates problems for me as a developer and it is confusing.
The reason that I run with the HTML validator turned off is because the validator displays validation errors when it encounters partial HTML tags. I may have partial HTML tags in a JSP file because they are nested in conditional statements. For example, a beginning HTML tag may appear several times because it is nested inside of serveral conditional <c:when> tags. The closing HTML tag may only appear once outside of the conditional statement. So, if JSTL/Struts tag validation is tied to the HTML validator, I either have to live with the HTML errors or do without JSTL/Struts validation.
The reason that it is confusing is that JSTL/Struts tags are not HTML tags, but they are considered part of the JSP custom tag library. Some developers like myself would naturally assume their validation is then tied to JSP validation.
Could you mention this problem to your developers? I don’t know why they decided to wrap this under the control of the HTML validation preference. If they had issues with having it under the JSP validation, maybe custom JSP tag validation could be placed under its own preference.
Anyway, I hope this helps.
Keith
