[dtbullock]

… is broken!

specifically:

    
    public static Session currentSession() throws HibernateException {
        Session session = (Session) threadLocal.get();

        if (session == null) {
            if (sessionFactory == null) {
                try {
                    cfg.configure(CONFIG_FILE_LOCATION);
                    sessionFactory = cfg.buildSessionFactory();
                }
                catch (Exception e) {
                    System.err.println("%%%% Error Creating SessionFactory %%%%");
                    e.printStackTrace();
                }
            }
            session = sessionFactory.openSession();
            threadLocal.set(session);
        }

        return session;
    }

… eats up an exception and logs it, only to cause a NullPointerException next statement after the handler has executed. Might as well throw e after you’ve printStackTraced()’d it.

[Riyad Kalla]

I will bring this to the attention of the proper team, thank you for pointing it out.

[Author]

Posts