- This topic has 6 replies, 3 voices, and was last updated 20 years, 11 months ago by Riyad Kalla.
-
AuthorPosts
-
Riyad KallaMemberME: 2.7rc1
E: 2.1.2Colors are not honored with syntax highlighting. I found this with the taglib coloring (it worked when I first set it) but after restarting and hitting apply 100x and changing the color, it doesn’t work any longer.
I haven’t tested this with the other editors, so it may be bigger than just the JSP editor.
Riyad KallaMemberfollowup: it seems the coloring is totally erradic… I close that file you see in the background of the screenshot, reopened it, it was still wrong. So I switched tabs, and switched back and its fine now. So I closed it and opened it again, and it opened wrong (all green) THEN after about 1/2 a second, the colorer kicked in and ran through and colored all the taglibs that orange color… why doesn’t the syntax highlighter color it the correct color on the first past? Does it COST me coloring performance to be using custom colors? (aka 2 passes)
Also may some more diverse defaults for the colors would help, my problem now is that I can’t quickly see where my taglibs VERSUS html are in the file.
Scott AndersonParticipantRiyad,
Perhaps there’s just a little confusion here. Let me explain what happens and you can see if this matches your experiences.
In web projects, there’s a lot for the JSP system to keep track of and validate on. Java classes, custom taglibs, syntax, etc. In order to validate properly, the JSP system has to parse and cache information on all of these items, in addition to scanning hte JSP you’re trying to edit. We’ve done our best to do most of this in the background, cache the information, and then invalidate it as you add or delete taglibs, etc. However, when you first pop open a JSP file in a project containing lots of taglibs there may be a delay while all the validation information is gathered. While this is going on in the background, the syntax colorer can’t distinguish between custom taglibs, errors, etc. So, it does a “syntax only” coloring and then when all the cached symantic content is available it recolors using this information. That’s why you might see the jsp taglib references show up in a default color, and then change color after they are recognized, when the parsing and caching is complete.
Does that explanation seem to match with your experiences?
–Scott
MyEclipse Support
Riyad KallaMemberOh ok that makes a lot of sense. This does match my experience when I open the file, see a pause, then see the file recolor itself. But from my first post you can see on a file that has been open quite a while, the setting for the color isn’t honored.
I’ll keep my eye on this bug as it doesn’t seem to popup very often, go ahead and close this I’ll add a reply if it starts acting squirrely.
Scott AndersonParticipantSounds like a plan. If it acts peculiar, it would be great to have a reproducable test case, naturally. 🙂
–Scott
MyEclipse Support
support-michaelKeymasterAn added behavior in the 2.7RC1 JSP Editor’s coloring logic is to ignore undefined tags. So if your JSP lacks a taglib directive for a particular namespace then the tags are colored as normal. Per the spec there are JSP tags, custom tags, and unknown tags. Unknown tags are ignored and colored normal.
Michael
MyEclipse Support
Riyad KallaMemberThanks for the update
-
AuthorPosts